Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another nil check fix in BlockStorageProviderSuite #3160

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

pavannd1
Copy link
Contributor

Change Overview

The check.v1 refactor PR introduced a test bug by changing the expected result here.
Similar to #3159

I explored the entire PR. This is the last one that requires a fix but I could be wrong.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test
  • 🏗️ Build

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Copy link
Contributor

@bathina2 bathina2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavannd1 pavannd1 added the kueue label Sep 25, 2024
@mergify mergify bot merged commit 701f6d0 into master Sep 25, 2024
18 checks passed
@mergify mergify bot deleted the fix-blkstr-test-1 branch September 25, 2024 19:40
@julio-lopez
Copy link
Contributor

Thanks @pavannd1 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants